Conversation
Ensure that we use that path that will be generated by meson using
`get_option('prefix') / get_option('libdir') / 'wayfire'`.
Note: the 'libdir' component can vary among systems; while most often it is just `lib`, e.g. on Ubuntu, it is `lib/x86_64-linux-gnu'.
Nice work, this is basically exactly what I had in mind. (aside from the
How about |
| { | ||
| plugin_prefixes.push_back(xdg_data_dir + "/wayfire/plugin-manager/install/lib/wayfire"); | ||
| plugin_prefixes.push_back(xdg_data_dir + "/wayfire/plugin-manager/install/lib64/wayfire"); | ||
| // REL_LIBDIR from meson.build: get_option('libdir') to be compatible with wayfire-plugin |
There was a problem hiding this comment.
can't we push the old paths just so that this is backwards compatible?
There was a problem hiding this comment.
Yes, we could -- my thinking was that cases where things worked with plugins using get_option('libdir') will continue to do so. The only breakage will come from when the plugin build was manually adjusted to the hardcoded path (which I expect not to be common, since I was the first one reporting the issue). But in any case, better to be safe, so I'll add the old paths explicitly.
There was a problem hiding this comment.
OK, just pushed an update to include the original paths here. BTW, I was wondering whether it would make sense to use fs::path here as well as it is done in plugin.cpp (e.g. here)
There was a problem hiding this comment.
would be nice, if you feel like updating the code once again :)
There was a problem hiding this comment.
Yes, I'm happy to look into this, but might be only during the weekend / next week
3 participants
Fixes #3124
Ensure that we use that path that will be generated by meson using
get_option('prefix') / get_option('libdir') / 'wayfire'.Note: the 'libdir' component can vary among systems; while most often it is just
lib, e.g. on Ubuntu, it is `lib/x86_64-linux-gnu'.Note: I'm not that happy with the
REL_LIBDIRname for this variable, happy to hear alternate suggestions :)