Skip to content

wcm: support metadata files installed by wayfire-plugin - #124

Merged
soreau merged 1 commit into
WayfireWM:masterfrom
dkondor:wayfire_plugin_xml
Sep 4, 2026
Merged

soreau merged 1 commit into
WayfireWM:masterfrom
dkondor:wayfire_plugin_xml

Conversation

@dkondor

@dkondor dkondor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #123

This is the simple way, hardcoding the same path logic that Wayfire uses. As discussed in #123, an alternative would be for Wayfire to export the (relative) paths via pkg-config or similar mechanism. However, I'm now in favor of this simpler option, since:

  • I expect that the paths will likely not change often
  • Any such change would require rebuilding wcm anyway, while the update needed here would be trivial

A further alternative would be for Wayfire to instead always provide the WAYFIRE_PLUGIN_XML_PATH instead -- while maybe a bit more complex, in that case, no change to wcm would be needed.

@soreau

soreau commented Sep 4, 2026

Copy link
Copy Markdown
Member

This is par for the course, so far as wcm is concerned. LGTM, I will assume you've tested this.

@soreau
soreau merged commit a2dd70d into WayfireWM:master Sep 4, 2026
2 checks passed
@soreau

soreau commented Sep 4, 2026

Copy link
Copy Markdown
Member

Thanks!

@dkondor
dkondor deleted the wayfire_plugin_xml branch September 5, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better support for wayfire-plugin?

2 participants