wf-dock: improve finding icon for some GNOME apps #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes finding icon for gedit on Ubuntu 24.04
handle when the .desktop file start with a capital letter; fixes evince (org.gnome.Evince) and devhelp (org.gnome.Devhelp) on Ubuntu 24.04
|
Closing this, as I realized I used my master branch for this PR and I need to update it. I'll leave #274 open and let me know there if this limited approach is preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much more limited attempt than #82
Running on Ubuntu 24.04, this fixes finding icons for at least gedit (org.gnome.gedit), evince (org.gnome.Evince) and devhelp (org.gnome.Devhelp).
Let me know if moving this to a common util (with wf-panel) is still desired.