Fix a bunch of accessibility issues! #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Links now pass AAA WCAG for colour contrast! and they have underlines where they didn't before - Thin (maybe too thin) custom scrollbars are gone, letting the user's OS determine what's best (and not violating their scrollbar expectations either) - Added a title attribute to the twitter link down at the bottom, so assistive devices know what's goin' on - Put the textarea in the sign up form inside its label, like the rest of the form elements, so that it's clear what the label labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where they didn't before
OS determine what's best (and not violating their scrollbar
expectations either)
assistive devices know what's goin' on
of the form elements, so that it's clear what the label labels