Update TypeUpdating for exact heap types #7452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve exactness while updating the underlying heap type definitions when copying old types into the new builder. Also fall back to updating the underlying heap type definition while preserving exactness when when updating the module's types if the mapping does not contain an explicit mapping for an exact type.
kripken
approved these changes
Apr 4, 2025
| if (iter != oldToNewTypes.end()) { | ||
| return iter->second.with(Exact); | ||
| } | ||
| } |
There was a problem hiding this comment.
It might be a little more efficient and perhaps clear if we put the normal path and the exact path in separate if arms? That is, there is no need to try the normal path first before the exact one, if we are exact, IIANM
There was a problem hiding this comment.
I was thinking that it would be nice to have the flexibility to map exact types to inexact types, but I think YAGNI is the correct response here. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve exactness while updating the underlying heap type definitions
when copying old types into the new builder. Also fall back to updating
the underlying heap type definition while preserving exactness when when
updating the module's types if the mapping does not contain an explicit
mapping for an exact type.