Add initial packed waitqueue type - #8323
Merged
Merged
Conversation
stevenfontanella
marked this pull request as ready for review
February 13, 2026 07:26
kripken
reviewed
Feb 13, 2026
kripken
approved these changes
Feb 13, 2026
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
Seems the spec discussion is ongoing but lgtm to land this if it helps investigation for the spec.
Member
|
Oh, I would fuzz this before landing. I wouldn't be surprised if the fuzzer can do something surprising with the new testcase here - may need to disallow it. |
Also change unreachable message
Member
Author
|
Will fuzz before merging and add a validator rule disallowing WaitQueue fields unless shared everything threads is enabled in the next PR. |
Member
Author
|
Ran the fuzzer for 9000 iterations with no errors. It hit an error at the end but it was due to a stack overflow from a Wasm binary with a deep call stack and succeeded after I increased my stack size (and was the same from main as my branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8315. Adds initial binary + text parsing and printing for the packed waitqueue type.
Beyond the rest of the functionality, we also need to add validator rules that waitqueue can only be used when shared everything threads is enabled. Will add that in the next PR.