Skip to content

[test] Remove OrderedDict usage - #8338

Merged
sbc100 merged 1 commit into
mainfrom
OrderedDict
Feb 18, 2026
Merged

[test] Remove OrderedDict usage#8338
sbc100 merged 1 commit into
mainfrom
OrderedDict

Conversation

@sbc100

@sbc100 sbc100 commented Feb 18, 2026

Copy link
Copy Markdown
Member

Builtin dicts are guaranteed ordered as of 3.7 and we require 3.10 these days.

Also, document the 3.10 requirement in the README file and make the runtime
checks consistent.

@sbc100
sbc100 requested review from kripken and tlively February 18, 2026 04:26
@sbc100
sbc100 enabled auto-merge (squash) February 18, 2026 17:03
@kripken

kripken commented Feb 18, 2026

Copy link
Copy Markdown
Member

Where do we require 3.10? I see that in a few specific scripts, but not in the main check.py or README. lgtm with docs in the README.

@sbc100

sbc100 commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

Where do we require 3.10? I see that in a few specific scripts, but not in the main check.py or README. lgtm with docs in the README.

$ git grep sys.version
scripts/fuzz_opt.py:assert sys.version_info >= (3, 10), 'requires Python 3.10'
scripts/gen-s-parser.py:if sys.version_info < (3, 10):  # noqa: UP036

@sbc100

sbc100 commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

The requirement for 3.10 looks like it was added in #8125

@kripken

kripken commented Feb 18, 2026

Copy link
Copy Markdown
Member

Makes sense, yeah, I just think we should document it outside of those 2 side scripts, in a prominent place, so it's clear it is a requirement of the entire project.

@sbc100

sbc100 commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

It also in our .ruff.toml file: `target-version = "py310"

@sbc100

sbc100 commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

Done

Builtin dicts are guaranteed ordered as of 3.7 and we require 3.10 these
days.
@sbc100
sbc100 merged commit cc5d229 into main Feb 18, 2026
17 checks passed
@sbc100
sbc100 deleted the OrderedDict branch February 18, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants