Make future and stream element types optional #440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the same reason that
variant
andresult
case payloads andfunc
results are optional, it seems like the element types offuture
andstream
should be optional, allowing them to convey (single-shot or recurring) timing events. When the element-type is absent, theptr
(read-from or written-to) is simply ignored (as ifelem_size(Unit) == 0
, but without the messy implications if we did this in general). This is already present in the current implementation forfuture
(but not yetstream
), so this helps converge the spec with the impl.(credit to @rvolosatovs for pointing out the omission)