Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make future and stream element types optional #440

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

lukewagner
Copy link
Member

For the same reason that variant and result case payloads and func results are optional, it seems like the element types of future and stream should be optional, allowing them to convey (single-shot or recurring) timing events. When the element-type is absent, the ptr (read-from or written-to) is simply ignored (as if elem_size(Unit) == 0, but without the messy implications if we did this in general). This is already present in the current implementation for future (but not yet stream), so this helps converge the spec with the impl.

(credit to @rvolosatovs for pointing out the omission)

Co-authored-by: Joel Dice <[email protected]>
@lukewagner lukewagner merged commit f0dab1b into main Jan 17, 2025
2 checks passed
@lukewagner lukewagner deleted the optional-elem-types branch January 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants