-
Notifications
You must be signed in to change notification settings - Fork 89
Add thread.spawn_indirect
#447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fdeba12
Add `thread.spawn_indirect`
abrown dc32595
Fix `shared` syntax for ``
abrown 903cdb1
Fix table type: it contains shared `funcref`s
abrown 03d166d
Update design/mvp/CanonicalABI.md
abrown d394e76
Update design/mvp/CanonicalABI.md
abrown 90ac9d4
Update design/mvp/CanonicalABI.md
abrown 0e4defb
Update design/mvp/CanonicalABI.md
abrown 7b9a6ba
Update design/mvp/CanonicalABI.md
abrown 1c5f3c9
Update design/mvp/Explainer.md
abrown 4ac8c1c
Update design/mvp/Binary.md
abrown 34a5579
Update design/mvp/Explainer.md
abrown 9e9087e
Update design/mvp/CanonicalABI.md
abrown 1588a27
Update design/mvp/CanonicalABI.md
abrown deadb36
Update design/mvp/CanonicalABI.md
abrown 83f20a7
Move `thread.*` encodings to the 0x40+ space
abrown fbbceb1
Fix Markdown links
abrown cb42911
Fix line wrapping
abrown 3189ccc
Update design/mvp/CanonicalABI.md
abrown 1c558c7
Fix up `thread.spawn_ref` variables
abrown e4ea201
Update design/mvp/Explainer.md
abrown eb4f9c7
Update design/mvp/Binary.md
abrown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table type doesn't seem to follow any syntax defined in the proposal. More importantly, we have subtyping. So I think this ought to say:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks, good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in #462.