-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging future features with icon. #839
Conversation
Love this idea. It's simple and effective. I added support on the website for rendering these emojis as HTML images (just as GitHub does when it renders Unicode emoji characters in Markdown) so that they're more accessible. I believe the unicorn, in particular, is relatively new to the Unicode spec. One question: are you okay with some editors not being able to display these characters when editing? We could replace 🦄 with |
@@ -250,12 +250,12 @@ Each table definition declares an *element type*, *initial length*, and | |||
optional *maximum length*. | |||
|
|||
In the MVP, the only valid element type is `"anyfunc"`, but in the | |||
[future](FutureFeatures.md#more-table-operators-and-types), more element | |||
[future 🦄e](FutureFeatures.md#more-table-operators-and-types), more element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: trailing e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Heh, I like it too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Should MVP be 💩?
The encoding is split into three layers: | ||
|
||
* **Layer 0** is a simple binary encoding of the bytecode instructions and related data structures. | ||
The encoding is dense and trivial to interact with, making it suitable for | ||
scenarios like JIT, instrumentation tools, and debugging. | ||
* **Layer 1** provides structural compression on top of layer 0, exploiting | ||
* **Layer 1** 🦄 provides structural compression on top of layer 0, exploiting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to make all of these links IMO. This style should work:
Hello, [🦄][🦄] World!
...
Way at the bottom of the page...
[🦄][🦄]: PostMVP.md
Does this:
Hello, 🦄 World!
...
Way at the bottom of the page...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed should always be a link. Moving to the footnote style.
57d4e22
to
ca0db1b
Compare
Added brief item on multiple return.
Switched to ::unicorn:: style and footnotes. PTAL |
I don't understand the argument for |
Not all browsers support it. |
LGTM, I think it's a tad more accessible across environments. |
Added brief item on multiple return.