Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging future features with icon. #839

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

flagxor
Copy link
Member

@flagxor flagxor commented Oct 27, 2016

Added brief item on multiple return.

@s3ththompson
Copy link
Member

s3ththompson commented Oct 27, 2016

Love this idea. It's simple and effective.

I added support on the website for rendering these emojis as HTML images (just as GitHub does when it renders Unicode emoji characters in Markdown) so that they're more accessible. I believe the unicorn, in particular, is relatively new to the Unicode spec.

One question: are you okay with some editors not being able to display these characters when editing? We could replace 🦄 with :unicorn: and still reap the above support for rendering as emoji...

@@ -250,12 +250,12 @@ Each table definition declares an *element type*, *initial length*, and
optional *maximum length*.

In the MVP, the only valid element type is `"anyfunc"`, but in the
[future](FutureFeatures.md#more-table-operators-and-types), more element
[future 🦄e](FutureFeatures.md#more-table-operators-and-types), more element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing e

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lukewagner
Copy link
Member

Heh, I like it too.

Copy link
Member

@jfbastien jfbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Should MVP be 💩?

The encoding is split into three layers:

* **Layer 0** is a simple binary encoding of the bytecode instructions and related data structures.
The encoding is dense and trivial to interact with, making it suitable for
scenarios like JIT, instrumentation tools, and debugging.
* **Layer 1** provides structural compression on top of layer 0, exploiting
* **Layer 1** 🦄 provides structural compression on top of layer 0, exploiting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to make all of these links IMO. This style should work:

Hello, [🦄][🦄] World!

...

Way at the bottom of the page...

  [🦄][🦄]: PostMVP.md

Does this:

Hello, 🦄 World!

...

Way at the bottom of the page...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed should always be a link. Moving to the footnote style.

@flagxor flagxor force-pushed the tag_future branch 2 times, most recently from 57d4e22 to ca0db1b Compare October 27, 2016 18:29
Added brief item on multiple return.
@flagxor
Copy link
Member Author

flagxor commented Oct 27, 2016

Switched to ::unicorn:: style and footnotes.

PTAL

@jfbastien
Copy link
Member

I don't understand the argument for :unicorn: when Unicode has exactly what's needed, and it works. You can load 🦄 using fonts if thats necessary (just need to load one character too).

@flagxor
Copy link
Member Author

flagxor commented Oct 27, 2016

Not all browsers support it.
Also the OSX terminal treats it as a double wide character, so it covers the ] at the end of the tag when I edit. (And I don't have to keep it in the clipboard to type it).

@s3ththompson
Copy link
Member

LGTM, I think it's a tad more accessible across environments.

@s3ththompson s3ththompson merged commit 93e4e3b into WebAssembly:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants