Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding and decoding of tag imports. #102

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix encoding and decoding of tag imports. #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interpreter/binary/decode.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,7 @@ let import_desc s =
| 0x01 -> TableImport (table_type s)
| 0x02 -> MemoryImport (memory_type s)
| 0x03 -> GlobalImport (global_type s)
| 0x04 -> TagImport (at var s)
| 0x04 -> TagImport (tag_type s)
| _ -> error s (pos s - 1) "malformed import kind"

let import s =
Expand Down
6 changes: 3 additions & 3 deletions interpreter/binary/encode.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ struct
| TableImport t -> byte 0x01; table_type t
| MemoryImport t -> byte 0x02; memory_type t
| GlobalImport t -> byte 0x03; global_type t
| TagImport t -> byte 0x04; var t
| TagImport t -> byte 0x04; tag_type t

let import im =
let {module_name; item_name; idesc} = im.it in
Expand Down Expand Up @@ -1002,8 +1002,8 @@ struct
section 6 (vec global) gs (gs <> [])

(* Tag section *)
let tag tag =
tag_type tag.it.tgtype
let tag (t : tag) =
byte 0x00; var t.it.tgtype

let tag_section ts =
section 13 (vec tag) ts (ts <> [])
Expand Down