[0.3] Rework handlers and worlds #199
Merged
+82
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require a fair bit of renaming churn across several repos which I will help with if this is accepted. |
lann
force-pushed
the
proxy-to-service
branch
2 times, most recently
from
dbd35fa to
1077c9e
Compare
lann
changed the title
lann
force-pushed
the
proxy-to-service
branch
from
1077c9e to
5a56ac5
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
lukewagner
reviewed
Oct 14, 2025
lann
force-pushed
the
proxy-to-service
branch
from
40e3f32 to
c3ddcf5
Compare
- Add a `client` interface with a `send` function matching `handle` - Replace the `imports` world's `handler` import with `client` - Replace the `proxy` world with `service` - Add a `middleware` world
lann
force-pushed
the
proxy-to-service
branch
from
c3ddcf5 to
a059ac1
Compare
lann
force-pushed
the
proxy-to-service
branch
from
a059ac1 to
6ee48a5
Compare
Co-authored-by: Luke Wagner <[email protected]>
lann
force-pushed
the
proxy-to-service
branch
from
cd92e0b to
10a3d63
Compare
sunfishcode
reviewed
Oct 16, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientinterface with asendfunction matchinghandleproxyworld withserviceimportsworld intoservicehandlerimport withclientmiddlewareworldRef #167