wasi:[email protected]: Add tests for unlink errors #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingo
force-pushed
the
filesystem-unlink-errors
branch
2 times, most recently
from
89c4f76 to
a6d9fc9
Compare
wingo
changed the title
wingo
force-pushed
the
filesystem-unlink-errors
branch
from
a6d9fc9 to
344e0ee
Compare
wingo
commented
Oct 3, 2025
| assert_eq!(rm("/etc/passwd").await, Err(ErrorCode::NotPermitted)); | ||
| assert_eq!(rm("/etc/passwd").await, Err(ErrorCode::NotPermitted)); | ||
| assert_eq!(rm("z.txt").await, Err(ErrorCode::NoEntry)); | ||
| assert_eq!(rm("parent/z.txt").await, Err(ErrorCode::NotPermitted)); |
There was a problem hiding this comment.
All of these errors follow POSIX, and I think that if Windows diverges, there should be some adapter code. WDYT @alexcrichton ?
There was a problem hiding this comment.
In theory that seems reasonable to me yeah. Given how tricky this can be though I wouldn't be confident in saying it's the best solution until there's an implementation. For example a simple "map this code to that code" is totally fine, but if it otherwise requires a lot of other contextual information or flags-on-files or something then that's less reasonable. I'm not sure which bucket this would fall into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.