Skip to content

Conversation

wingo
Copy link
Collaborator

@wingo wingo commented Sep 16, 2025

No description provided.

@wingo wingo force-pushed the filesystem-open-errors branch 2 times, most recently from f81a49c to 9f9c44b Compare September 22, 2025 09:57
@wingo wingo changed the title wasi:[email protected]: Add tests for errors during open wasi:[email protected]: Add tests for errors during open Sep 22, 2025
@wingo wingo force-pushed the filesystem-open-errors branch from 9f9c44b to 5f9e6a0 Compare September 22, 2025 11:44
@wingo wingo marked this pull request as ready for review September 22, 2025 14:32
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its not done elsewhere, this is a good place to check that symbolic links that escape the preopen can't be opened

@wingo wingo force-pushed the filesystem-open-errors branch from 5f9e6a0 to 67418b0 Compare October 7, 2025 07:36
@wingo
Copy link
Collaborator Author

wingo commented Oct 7, 2025

On Windows the logs show an error:

Test filesystem-open-errors failed
  [exit_code] 0 == 3
STDOUT:

STDERR:

thread '<unnamed>' (1) panicked at src/bin/filesystem-open-errors.rs:40:5:
assertion `left == right` failed
  left: ErrorCode { code: 19, name: "no-entry", message: "No such file or directory, similar to `ENOENT` in POSIX." }
 right: ErrorCode { code: 30, name: "not-permitted", message: "Operation not permitted, similar to `EPERM` in POSIX." }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Error: failed to run main module `tests\rust\testsuite\wasm32-wasip3\filesystem-open-errors.wasm`

@wingo wingo force-pushed the filesystem-open-errors branch from 67418b0 to 1b983ed Compare October 7, 2025 12:16
@wingo
Copy link
Collaborator Author

wingo commented Oct 7, 2025

Whoops, I take it back, it was just missing a rebase. Tests passing on Windows, MacOS, Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants