Skip to content

Sync with the latest wasi-proposal-template #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Sync with the latest wasi-proposal-template #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: WebAssembly/wit-abi-up-to-date@v2
- uses: WebAssembly/wit-abi-up-to-date@v6
with:
wit-abi-tag: wit-abi-0.1.0
wit-abi-tag: wit-abi-0.6.0
2 changes: 1 addition & 1 deletion proposal-template.abi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ Size: 16, Alignment: 8
Explanation for developers using the API.
##### Results

- <a href="#api_function_one." name="api_function_one."></a> ``: [`api-type-one`](#api_type_one)
- [`api-type-one`](#api_type_one)

2 changes: 1 addition & 1 deletion proposal-template.wit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ More rigorous specification details for the implementer go here, if needed.
/// Short description
///
/// Explanation for developers using the API.
api-function-one: function() -> api-type-one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these templates live in the proposal itself? Shouldn't it be instances of the templates that live here? (apologies I've not be following the proposal template stuff).

i.e. shouldn't the templates get renamed when a proposal is started?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we should rename them when we start using them.
this PR is meant to be the minimum ci fix.

i personally prefer to remove them until we actually start using them: #23

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I was just curious. This pr seems fine.

api-function-one: func() -> api-type-one
```

If needed, this would explain what a compliant implementation MUST do, such as never returning an earlier result from a later call.