Add tests for referenceTarget interaction with ARIA attributes #43167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riately. https://bugs.webkit.org/show_bug.cgi?id=290440 Reviewed by NOBODY (OOPS!). This introduces a method on AXObjectCache to mark relations dirty when a referenceTarget value is changed. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-activedescendant-expected.txt: Added. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-activedescendant.html: Added. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleReferenceTargetChanged): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/dom/ShadowRoot.cpp: (WebCore::ShadowRoot::setReferenceTarget):
https://bugs.webkit.org/show_bug.cgi?id=290601 Reviewed by NOBODY (OOPS!). This adds tests for aria-controls, aria-describedby and aria-owns. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-controls-expected.txt: Added. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-controls.html: Added. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-describedby-expected.txt: Added. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-describedby.html: Added. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-owns-expected.txt: Added. * LayoutTests/accessibility/shadow-dom/reference-target/mac/aria-owns.html: Added.
alice
added
the
New Bugs
|
EWS run on current version of this PR (hash 272197c) |
|
(Note: I will rebase before landing, so this will only have the most recent change.) |
|
Need to update the branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
272197c
cb92a92
272197c
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp🛠 watch