[GTK] BubblewrapLauncher.cpp: Add /run/pulse to bindPulse() https://bugs.webkit.org/show_bug.cgi?id=297209

[lanodan]

39ac1a6

[GTK] BubblewrapLauncher.cpp: Add /run/pulse to bindPulse() https://bugs.webkit.org/show_bug.cgi?id=297209

Reviewed by Adrian Perez de Castro.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindPulse):

Canonical link: https://commits.webkit.org/298495@main

bf3cd71

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	💥 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 78eec8a)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[nikolaszimmermann]

Thanks for the contribution, it would be helpful if you could describe the scenario which is currently failing and how your patch addresses it.

[lanodan]

Thanks for the contribution, it would be helpful if you could describe the scenario which is currently failing and how your patch addresses it.

As put as comment, this is needed when pulseaudio (or pipewire-pulse) is a system daemon rather than a user service.

[philn]

This needs a bug report, please follow the guidelines: https://docs.webkit.org/Getting%20Started/ContributingCode.html#submitting-a-pull-request

[mcatanzaro]

Code changes are clearly fine, just need to include a bug report link and rewrite that comment as requested. Thank you!

[aperezdc]

@lanodan Could you update the patch as per the review comments? Thanks!

[webkit-early-warning-system]

EWS run on current version of this PR (hash bf3cd71)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	💥 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[aperezdc]

@lanodan Thanks for the update, but this still needs to refer to an issue in Bugzilla. I have created one for this. Could you use git-webkit commit --amend -i 297211 to reformat the commit message so it includes the issue reference, and update the PR once more? Thanks!

[aperezdc]

I see the commit message is actually correct, it's only the PR description that wasn't updated. Approved. The merge-queue should be happy with this, I think.

[webkit-commit-queue]

Committed 298495@main (39ac1a6): https://commits.webkit.org/298495@main

Reviewed commits have been landed. Closing PR #47024 and removing active labels.

[aperezdc]

Backported into webkitglib/2.48 as commit eeeb0a0

[aperezdc]

Backported into webkitglib/2.50 as commit f344770