Skip to content

Fix buffering handling in progressive playback #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: wpe-2.46
Choose a base branch
from
+14 −0
Draft

Fix buffering handling in progressive playback #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14bf121
Fix buffering handling in progressive playback
filipe-norte-red Aug 6, 2025
5040178
Revert "Fix buffering handling in progressive playback"
filipe-norte-red Aug 13, 2025
4fcc021
Fix buffering handling in progressive playback
filipe-norte-red Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,6 +2104,8 @@ void MediaPlayerPrivateGStreamer::handleMessage(GstMessage* message)
if (!messageSourceIsPlaybin || m_isDelayingLoad)
break;

updateBufferingStatus();

// The MediaPlayerPrivateGStreamer superclass now processes what it needs by calling updateStates() in handleMessage() for
// GST_MESSAGE_STATE_CHANGED. However, subclasses still need to override asyncStateChangeDone() to do their own stuff.
didPreroll();
Expand Down Expand Up @@ -2404,6 +2406,17 @@ void MediaPlayerPrivateGStreamer::updateBufferingStatus(GstBufferingMode mode, d
boolForPrinting(m_wasBuffering), boolForPrinting(m_isBuffering), m_previousBufferingPercentage, m_bufferingPercentage);
}

void MediaPlayerPrivateGStreamer::updateBufferingStatus()
{
std::optional<int> percentage = queryBufferingPercentage();

if (!percentage.has_value()) {
GST_DEBUG_OBJECT(pipeline(), "[Buffering] Unable to determine buffering status");
return;
}
updateBufferingStatus(GST_BUFFERING_DOWNLOAD, percentage.value(), false, false);
}

#if USE(GSTREAMER_MPEGTS)
void MediaPlayerPrivateGStreamer::processMpegTsSection(GstMpegtsSection* section)
{
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@ class MediaPlayerPrivateGStreamer
virtual void updateDownloadBufferingFlag();
void processBufferingStats(GstMessage*);
void updateBufferingStatus(GstBufferingMode, double percentage, bool resetHistory = false, bool shouldUpdateStates = true);
void updateBufferingStatus();
void updateMaxTimeLoaded(double percentage);

#if USE(GSTREAMER_MPEGTS)
Expand Down