Fix insertAdjacentHTML and createContextualFragment not working on non-HTML documents #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
Element.insertAdjacentHTML
andRange.createContextualFragment
resulted in crashes when used in XML documents, as they both rely on functionality from thetemplate
HTML element, which only works in HTML documents. I fixed the issue by adapting the logic used inHTMLTemplateElement
into a separate utility function.To test this, I've moved some tests from
html/element.js
tointerface/element.js
, as they don't apply just to HTML elements.I'm not sure how feasible it would be, and it is out of scope of this PR, but it might also make sense to make the interface tests run on all three document types, as such tests would've caught both errors fixed here.