Added exception handlers to SshConnection (#20)

openct/__main__.py

@@ -31,4 +31,4 @@
         if device.is_available():
             device.fetch_backup()
         else:
-            logging.error("Could not connect to device")
+            logging.error("Could not connect to device %s", host)

openct/connections/connections.py

@@ -1,9 +1,11 @@
 """Module for connection protocols"""
 
 from typing import Protocol
+import logging
 
 from fabric import Connection as FabricConnection
-from paramiko.ssh_exception import SSHException
+from paramiko.ssh_exception import SSHException, NoValidConnectionsError
+from invoke import UnexpectedExit
 
 
 class DeviceConnection(Protocol):
@@ -43,7 +45,8 @@ def test_connection(self) -> bool:
             try:
                 connection.open()
                 return True
-            except (TimeoutError, SSHException):
+            except (TimeoutError, SSHException, NoValidConnectionsError):
+                logging.error("Could not connect to device %s", self.ip_address)
                 return False
 
     def fetch_backup(self) -> None:
@@ -53,8 +56,13 @@ def fetch_backup(self) -> None:
             connect_timeout=self.connection_timeout,
             connect_kwargs={"key_filename": self.key_file},
         ) as connection:
-            connection.run("/export file=backup", hide=True, warn=False)
-            connection.get(
-                "backup.rsc", f"{self.backup_dir}/backup_{self.ip_address}.rsc"
-            )
-            connection.run("file/remove backup.rsc", hide=True, warn=False)
+            try:
+                connection.run("/export file=backup", hide=True, warn=False)
+                connection.get(
+                    "backup.rsc", f"{self.backup_dir}/backup_{self.ip_address}.rsc"
+                )
+                connection.run("file/remove backup.rsc", hide=True, warn=False)
+            except UnexpectedExit:
+                logging.error(
+                    "Error while fetching backup from device %s", self.ip_address
+                )

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "openct"
-version = "0.1.2"
+version = "0.1.3"
 description = "Configuration backup and analysis tools for devices running pfSense and RouterOS"
 authors = ["Weehooey <[email protected]>"]
 license = "GNU GPL v3.0"