Added backup directory to SshConnection (#16)

openct/__main__.py

@@ -25,6 +25,7 @@
             config.identity.username,
             config.settings.connection_timeout,
             config.identity.key_file,
+            config.dirs.backup_dir,
         )
 
         if device.is_available():

openct/connections/connections.py

@@ -20,12 +20,18 @@ class SshConnection(DeviceConnection):
     """DeviceConnection using Fabric"""
 
     def __init__(
-        self, ip_address: str, username: str, connection_timeout: int, key_file: str
+        self,
+        ip_address: str,
+        username: str,
+        connection_timeout: int,
+        key_file: str,
+        backup_dir: str,
     ) -> None:
         self.ip_address = ip_address
         self.username = username
         self.connection_timeout = connection_timeout
         self.key_file = key_file
+        self.backup_dir = backup_dir
 
     def test_connection(self) -> bool:
         with FabricConnection(
@@ -48,5 +54,7 @@ def fetch_backup(self) -> None:
             connect_kwargs={"key_filename": self.key_file},
         ) as connection:
             connection.run("/export file=backup", hide=True, warn=False)
-            connection.get("backup.rsc", f"backups/backup_{self.ip_address}.rsc")
+            connection.get(
+                "backup.rsc", f"{self.backup_dir}/backup_{self.ip_address}.rsc"
+            )
             connection.run("file/remove backup.rsc", hide=True, warn=False)

openct/devices/devices.py

@@ -4,6 +4,7 @@
 
 from openct.connections import DeviceConnection, SshConnection
 
+
 class Device(ABC):
     """Device abstract base class"""
 
@@ -22,10 +23,17 @@ class RouterOSDevice(Device):
     """RouterOS device"""
 
     def __init__(
-        self, ip_address: str, username: str, connection_timeout: int, key_file: str
+        self,
+        ip_address: str,
+        username: str,
+        connection_timeout: int,
+        key_file: str,
+        backup_dir: str,
     ) -> None:
         super().__init__(
-            SshConnection(ip_address, username, connection_timeout, key_file)
+            SshConnection(
+                ip_address, username, connection_timeout, key_file, backup_dir
+            )
         )
 
     def fetch_backup(self) -> str:

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "openct"
-version = "0.1.1"
+version = "0.1.2"
 description = "Configuration backup and analysis tools for devices running pfSense and RouterOS"
 authors = ["Weehooey <[email protected]>"]
 license = "GNU GPL v3.0"