-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: album message sending #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
This comment was marked as spam.
This comment was marked as spam.
purpshell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good quick solution, how about we instead add support for the root albumMessage and then have the children follow up with some property? This makes more sense to me
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
That makes more sense as if we need to change the upload logic some day, we'll have to also change this which could be easily overlooked. Adding a property like "parentkey" which is a key to the albumMessage should be good enough. It also allows for a lot of freedom as to when the messages get uploaded and allows people to run queueing, failsafes so on. |
|
I also implore you to see what the official client has in store for when more media is added beyond the first albumMessage, maybe a message edit is made with the new count. |
example