-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: implement automated WhatsApp version update workflow and related scripts #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
|
thank you for your work |
purpshell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current problem is that the protos are also out of date. The reason the version updates have been manual is due to proto gen.
We should somehow add to this action the grabbing of .proto files from the wppconnect wa-proto (stopgap till we implement ProtoCocktail) and putting them in here and generating protos (one thing to note is that we do need to downgrade the version and perform a replace for some weird attribute when running the .sh on the wppconnect protos, sure you'll figure it out)
| on: | ||
| schedule: | ||
| # Run on the 1st of every month at 02:00 UTC | ||
| - cron: '0 2 1 * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - cron: '0 2 1 * *' | |
| - cron: '0 2 1 * *' |
I believe that this should be more frequent. At least once a week or once every 2-3 weeks at most.
This is so every NPM release can have both ver and proto updates.
| --title "chore: update WhatsApp Web version" \ | ||
| --body "Automated WhatsApp Web version update. | ||
|
|
||
| This PR updates the WhatsApp Web client revision to the latest version fetched from \`web.whatsapp.com\`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note to collaborators / merge power users to test the version and validate pre-approval. Also, eventually this should be expanded to include E2E full tests against real sockets for the version.. I think this is something in the scope of WhiskeySockets Enterprise / DevTools tho
The permission is already there. |
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
This action will be executed every month to update the version of whatsapp.
This is a example of how the PR is created by this action: jlucaso1#8
Maybe we need to add permission of create PR to GH action: