feat: add cleanup handlers to prevent memory leaks on socket close #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
vinikjkkj
force-pushed
the
end-handlers
branch
from
a92c3ef to
8865e8b
Compare
Added `registerSocketEndHandler` to register cleanup callbacks that run when socket closes. Implemented cleanup in: - Signal repository: clear migrated session cache and LID mapping - Chats socket: clear sync timeout and placeholder resend cache - Messages recv: clear retry/call offer/placeholder caches and identity assert debounce - Messages send: clear user devices/peer sessions caches and media connection - Event buffer: add destroy
vinikjkkj
force-pushed
the
end-handlers
branch
from
8865e8b to
62e57cb
Compare
Contributor
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
registerSocketEndHandlerto register cleanup callbacks that run when socket closes. Implemented cleanup in: