Increase z-index for pledge background #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduces the z-index from 251 to 99, to avoid the form not being editable.
|
ah, i see why now - the sub-menu items are covered |
|
I would increase the z-index of the dialog— it's at 100 now, but it should be 252 (dialog overlay + 1). (honestly, I'm a little confused about missing this — I definitely used tested the edit flow, but maybe I only ever tested keyboard interaction…) |
Increase z-index
Add comment back in
pkevan
changed the title
|
As per #320 (comment) the z-index is being increased, which resolves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a temp fix for #319 - the old theme seems to have it set at this value so need a double-check on this in case there are unintended consequences of reducing it.
props martinkrcho