Try: Use WP_HTML_Processor in Optimization Detective #1546
+503
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Enhancement
westonruter
commented
Sep 19, 2024
westonruter
commented
Sep 19, 2024
| @@ -177,7 +177,14 @@ function od_optimize_template_output_buffer( string $buffer ): string { | |||
| } | |||
|
|
|||
| // If the initial tag is not an open HTML tag, then abort since the buffer is not a complete HTML document. | |||
| $processor = new OD_HTML_Tag_Processor( $buffer ); | |||
| if ( version_compare( get_bloginfo( 'version' ), strtok( '6.7', '-' ), '>=' ) ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( version_compare( get_bloginfo( 'version' ), strtok( '6.7', '-' ), '>=' ) ) { | |
| if ( version_compare( strtok( get_bloginfo( 'version' ), ','), '6.7' ), '>=' ) ) { |
Base automatically changed from
add/embed-optimizer-min-height-reservation
to
trunk
October 14, 2024 17:38
… try/od-html-processor
westonruter
changed the title
|
This is now unblocked for further experimentation, although one workaround is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem with HTML Tag Processor failing to parse malformed HTML: https://wordpress.org/support/topic/optimization-detective-floods-debug-log-od_html_tag_processornext_token/
Blockers:
OD_HTML_Tag_Processor#1861Core-62269 whereWP_HTML_Processor::next_token()cannot be extended in subclasses to keep track of state.Core-62290 where calls toWP_HTML_Processor::seek()fail.</body>. But there are workarounds.Related: #1919 (comment). We should consider not directly exposing the
OD_HTML_Tag_Processorto the tag visitors and template optimization start/finish action handlers since this then exposes theappend_head_html()andappend_body_html()methods which may not be desirable. This also exposes a lower-level API than which may be appropriate which will complicate switching between usingWP_HTML_Tag_ProcessorandWP_HTML_Processorimplementations. Namely, forWP_HTML_Processorthere may not be a need to add aget_xpath()method directly to the class, and we may not need to subclass it at all. If we instead passed a wrapper class, then we could expose aget_xpath()on the wrapper subclass which is then able to use the appropriate implementation based on whether it is usingWP_HTML_Tag_ProcessororWP_HTML_Processor. In fact, this could allow Optimization Detective to use an unsubclassed originalWP_HTML_Tag_Processorinstance which is provided by core for output-buffer manipulation instead of allowing filtering the underlying string (if that is so desired, per Core-43258).