Skip to content

Backport: Disable real-time collaboration on site editor #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alecgeatches wants to merge 5 commits into from
Closed

Backport: Disable real-time collaboration on site editor #11181

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
116d0d1
Backport gutenberg#76223 - disable RTC on site editor
alecgeatches Mar 5, 2026
574428c
Merge branch 'trunk' into backport/rtc-disable-site-editor
alecgeatches Mar 6, 2026
80728c6
Address PR feedback: Add global usage doc, remove site-editor-v2, use…
alecgeatches Mar 11, 2026
19e2a7b
Merge branch 'trunk' into backport/rtc-disable-site-editor
alecgeatches Mar 11, 2026
b4ebadd
Merge branch 'trunk' into backport/rtc-disable-site-editor
alecgeatches Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/wp-includes/collaboration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,24 @@
* @access private
*/
function wp_collaboration_inject_setting() {
if ( get_option( 'wp_enable_real_time_collaboration' ) ) {
wp_add_inline_script(
'wp-core-data',
'window._wpCollaborationEnabled = true;',
'after'
);
global $pagenow;
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing doc for global.

@global string $pagenow The filename of the current screen.


if ( ! get_option( 'wp_enable_real_time_collaboration' ) ) {
return;
}

// Disable real-time collaboration on the site editor.
$enabled = true;
if (
'site-editor.php' === $pagenow ||
( 'admin.php' === $pagenow && isset( $_GET['page'] ) && 'site-editor-v2' === $_GET['page'] )
Copy link
Copy Markdown
Member

@ellatrix ellatrix Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we have site-editor-v2 in core

) {
$enabled = false;
}

wp_add_inline_script(
'wp-core-data',
'window._wpCollaborationEnabled = ' . ( $enabled ? 'true' : 'false' ) . ';',
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a ternary ( $enabled ? 'true' : 'false' ), using wp_json_encode() is a cleaner, more "standard" way to pass PHP booleans into JavaScript.

'after'
);
}
Loading