Skip to content

#64832 Fix Upload Plugin form layout use flex box for file and submit#11216

Closed
PANawkar wants to merge 3 commits intoWordPress:trunkfrom
PANawkar:64832-local
Closed

#64832 Fix Upload Plugin form layout use flex box for file and submit#11216
PANawkar wants to merge 3 commits intoWordPress:trunkfrom
PANawkar:64832-local

Conversation

@PANawkar
Copy link
Copy Markdown

Fix the Upload Plugin/theme upload layout alignment

Wrap file input and Install Now in wp-upload-form-box; style as flex row so the button stays in the same grey box (fixes fr_FR and
avoids absolute positioning with top: auto, dropping the submit below). Update themes.css and themes-rtl.css; stack on narrow viewports.

Trac ticket: https://core.trac.wordpress.org/ticket/64832

Before:
Screenshot 2026-03-09 185457

Screenshot 2026-03-10 095046

After:
Screenshot 2026-03-10 095156

Screenshot 2026-03-10 095046

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 10, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pratik.nawkar@xecurify.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, pratiknawkar94.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change just restores the problem previously fixed in https://core.trac.wordpress.org/ticket/64065. Let's try to find a solution that allows us to keep the larger drop area.

@PANawkar PANawkar requested a review from joedolson March 12, 2026 04:06
@PANawkar
Copy link
Copy Markdown
Author

@joedolson, please let me know if any changes are needed in this PR.

@joedolson
Copy link
Copy Markdown
Contributor

@PANawkar Unfortunately, it doesn't seem to me that these changes have solved anything. The drop area is still only the small file input. The goal of the prior change was to make the file input cover the entire form space, so that the drop area is easier to hit; but this doesn't do that.

I'll look at it and see if there are other options.

@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62090
GitHub commit: 77850fb

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants