Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with the logo on the login page #7386

Closed
wants to merge 5 commits into from

Conversation

pamprn09
Copy link

@pamprn09 pamprn09 commented Sep 17, 2024

  • I've added a "Login" text inside the form and moved the <h1> tag to it. So now the WordPress logo is inside a div.
  • I also added a main tag to the page.
login-screen

Trac ticket: https://core.trac.wordpress.org/ticket/51786

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pamprn, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

src/wp-login.php Outdated Show resolved Hide resolved
Co-authored-by: Mukesh Panchal <[email protected]>
@joedolson
Copy link
Contributor

In r59138

@joedolson joedolson closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants