Plugins: Try blocks for single plugin page#460
Draft
ryelle wants to merge 1 commit intoWordPress:trunkfrom
Draft
Plugins: Try blocks for single plugin page#460ryelle wants to merge 1 commit intoWordPress:trunkfrom
ryelle wants to merge 1 commit intoWordPress:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went into this thinking I would just update the tabs, but then I got a little distracted 😅
This PR starts an attempt at block-ifying the single plugin page, instead of using a block to render a classic-theme template with some embedded block code.
wp:legacy-widgetblock. I don't think we can pass in args to update the headings, so maybe a filter + HTML processing, or maybe these should just be blockified faster.single-plugin.htmlcan load a partial which is filtered.Regarding tabs… The fact that the tabs are above the sidebar too also makes this harder — and the sidebar changes based on tab-view… so really there should be a sidebar-pattern for each tab, as well, since the "tabpanel" should contain all changing content. It's also hard to suss out from the code which elements show up when.
@StevenDufresne Feel free to take over this for iterating, or ignore it and just fix up the tabs :)