Skip to content

Load more button - #379

Merged
trymebytes merged 21 commits into
trunkfrom
load-more-btn
Jan 7, 2025
Merged

Load more button#379
trymebytes merged 21 commits into
trunkfrom
load-more-btn

Conversation

@trymebytes

@trymebytes trymebytes commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Fixes #378

  • Modify existing list endpoint to fetch next list of events
  • Call endpoint via AJAX when button is clicked

@trymebytes
trymebytes marked this pull request as ready for review November 29, 2024 14:16
Comment thread assets/js/translation-events.js Outdated
function ( e ) {
let eventType = $( this ).data('event-type');
let nextPage = $( this ).data('event-next-page');
const url = `http://translate.test/events/?${encodeURIComponent(eventType)}=${encodeURIComponent(nextPage)}&format=html`;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const url = `http://translate.test/events/?${encodeURIComponent(eventType)}=${encodeURIComponent(nextPage)}&format=html`;
const url = `https://translate.wordpress.org/events/?${encodeURIComponent(eventType)}=${encodeURIComponent(nextPage)}&format=html`;

@trymebytes
trymebytes requested a review from amieiro December 12, 2024 15:02
@trymebytes
trymebytes merged commit a44e9c5 into trunk Jan 7, 2025
@trymebytes
trymebytes deleted the load-more-btn branch January 7, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load more button

2 participants