fix(emails): visibility can be null
#756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [`/user/emails` schema](https://docs.github.com/en/rest/users/emails?apiVersion=2022-11-28#list-email-addresses-for-the-authenticated-user), the `visibility` field in the response can be `null`. The `UserEmailInfo` made it mandatory, causing deserialization failures during requests against real GitHub APIs like this: ``` invalid type: null, expected string or map ```
dndx
force-pushed
the
fix/visibility_optional
branch
from
234c7f8 to
e868271
Compare
|
@dndx This caught me by surprise and wasted me a good couple hours. Interestingly, this should always (?) fail because the no-reply email generated by github (I assume for all users?) has |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the
/user/emailsschema, thevisibilityfield in the response can benull. TheUserEmailInfomade it mandatory, causing deserialization failures during requests against real GitHub APIs like this: