Clean-room system menu administration#1666

Merged

mambax7 merged 58 commits intoXOOPS:masterfrom

mambax7:feature/system-menu-cleanroom

Mar 20, 2026

Commits on Mar 19, 2026

Revert "Add system menu management (downport from XOOPS 2.7.0)"
mambax7
committed
feat(menus): add system menu constant, config, and admin registration
mambax7
committed
feat(menus): add menu table creation and idempotent seed logic

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add XoopsMenusCategory kernel object and handler
mambax7
committed
feat(menus): add XoopsMenusItems kernel object and handler

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add SystemMenusTree validator with cycle and depth checks

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add loadMenus() and theme integration for frontend menu rendering

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add English language constants for menu admin

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add admin controller with CRUD, tree validation, and AJAX operations

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add admin template, CSS, and JavaScript with SortableJS

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add theme nav-menu templates with xoMenuCategories rendering

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add frontend multilevel menu CSS and JS

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add form description constants and disabled-item error messages

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add handler methods, getNewEnreg, language fallback, and form descriptions

XOOPS Core Team
authored and
mambax7
committed
fix(menus): improve theme integration — target strings, handler methods, robust inbox count

XOOPS Core Team
authored and
mambax7
committed
fix(menus): version-gate update, add FA icons, NULL migration, seed UPDATE, permission cleanup

XOOPS Core Team
authored and
mambax7
committed
fix(menus): block editing and deleting inactive menu items

XOOPS Core Team
authored and
mambax7
committed
fix(menus): add Escape key, click-outside, aria-expanded, and toolbar hook to frontend JS

XOOPS Core Team
authored and
mambax7
committed
fix(menus): use target strings, language constants in fallback, aria-expanded in theme templates

XOOPS Core Team
authored and
mambax7
committed
feat(menus): add menu icon PNGs for all admin themes and image field in xoops_version

XOOPS Core Team
authored and
mambax7
committed
test(menus): add regression tests for schema conventions, security, and disabled-item guards

XOOPS Core Team
authored and
mambax7
committed
fix(menus): use exec() for DDL/DML statements, query() only for SELECTs in update.php

XOOPS Core Team
authored and
mambax7
committed
fix(menus): remove @package tag from SystemMenusTree, fix test namespace typo

XOOPS Core Team
authored and
mambax7
committed
docs(menus): add //2.5.12 version markers to language files and update lang_diff.txt

XOOPS Core Team
authored and
mambax7
committed
refactor(menus): use xoops_loadLanguage() instead of manual language file loading

XOOPS Core Team
authored and
mambax7
committed
refactor(menus): rename form variables from $xxxEl to $xxxField for clarity

XOOPS Core Team
authored and
mambax7
committed
fix(menus): align test namespaces with existing modulessystem convention

XOOPS Core Team
authored and
mambax7
committed
updates
mambax7
committed
feat(menus): add xoops_cp_header/footer, breadcrumbs, xoAdminIcons, system_header.tpl, full parent chain check

XOOPS Core Team
authored and
mambax7
committed
docs(menus): add NAV_CATEGORY constant to lang_diff.txt

XOOPS Core Team
authored and
mambax7
committed
docs(menus): improve PHPDoc to explain why and who calls each method, not just what

XOOPS Core Team
authored and
mambax7
committed
fix(menus): fix regex delimiter collision in normalizeMenuUrl — # used as both delimiter and literal

XOOPS Core Team
authored and
mambax7
committed
fix(menus): restore full navbar wrapper in theme templates — was missing header, logo, collapse, search

XOOPS Core Team
authored and
mambax7
committed
fix(menus): set template_main before xoops_cp_header — admin page was rendering blank

XOOPS Core Team
authored and
mambax7
committed
fix(menus): include xoopsformloader before using form classes in getFormCat/getFormItems

XOOPS Core Team
authored and
mambax7
committed
fix(menus): include grouppermform.php — XoopsGroupPermForm is not in xoopsformloader

XOOPS Core Team
authored and
mambax7
committed
fix(menus): remove setDescription on XoopsGroupPermForm — method does not exist on that class

XOOPS Core Team
authored and
mambax7
committed
fix(menus): replace XoopsGroupPermForm with Xmf\Module\Helper\Permission for proper multi-select permissions

XOOPS Core Team
authored and
mambax7
committed
fix(menus): align item_id parameter name between JS, templates, and controller

XOOPS Core Team
authored and
mambax7
committed
Clean-room system menu administration
mambax7
committed
Address review findings: orphan guard, active-state check, version_compare, idempotent permissions
mambax7
committed
Update regression test to match idempotent permission seeding
mambax7
committed
Harden reorder, save, and update against crafted payloads
mambax7
committed
Fix double-escaping, viewcat markup, position base, dead code, and javascript: whitespace
mambax7
committed
Check insert() results in AJAX handlers, validate new item category, allow inactive deletion
mambax7
committed
Fix CI, harden handlers, allow inactive edit/delete, Scrutinizer cleanups
mambax7
committed
Check DB exec results, 1-based item positions
mambax7
committed
Short-circuit reorder on failure, whitelist constant resolution, Scrutinizer cleanups
mambax7
committed
Drop orphaned tree nodes, protect target on seed rows, harden isNew checks
mambax7
committed
Fail fast on delete errors, validate reorder tree shape and completeness
mambax7
committed
Exact item set validation for reorder, whitelist URL schemes
mambax7
committed
Order-insensitive set comparison, decode entities before URL scheme check
mambax7
committed
Split dropdown toggle from category link in frontend nav themes
mambax7
committed
Fix frontend nav dropdown: hover-open, split toggle, submenu arrows, hover highlight
mambax7
committed
Add touch-friendly dropdown: first tap opens submenu, second tap navigates
mambax7
committed
Extend touch-friendly tap to nested submenus
mambax7
committed
Title:
mambax7
committed

Commits on Mar 20, 2026

Close open dropdowns on outside tap
mambax7
committed