-
Notifications
You must be signed in to change notification settings - Fork 5
Modernize all dependencies for PHP 8.4+ #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mambax7
wants to merge
9
commits into
XOOPS:master
Choose a base branch
from
mambax7:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
65bbb84
composer updates
mambax7 cf4c1de
Update composer.json
mambax7 63764fb
Update composer.json
mambax7 277710d
Update smarty/smarty version in composer.json
mambax7 4e533b4
Update description for XOOPS base requires
mambax7 b8bc7db
PHP 8.4
mambax7 99cf1b6
Merge branch 'master' of https://github.com/mambax7/base-requires
mambax7 5977294
Add php-debugbar/php-debugbar ^3.3 dependency
mambax7 2ef8da0
Normalize ext-PDO to ext-pdo and remove redundant polyfill-mbstring
mambax7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,41 +4,42 @@ | |||||
| "type": "project", | ||||||
| "description": "Primary dependencies for XOOPS/XoopsCore", | ||||||
| "require": { | ||||||
| "php": ">7.1", | ||||||
| "php": ">8.2", | ||||||
| "dflydev/apache-mime-types": "1.0.*", | ||||||
| "doctrine/dbal": "^4.2.1", | ||||||
| "embed/embed": "^3.0.0", | ||||||
| "endroid/qr-code": "^6.0.8", | ||||||
| "ext-PDO": "*", | ||||||
| "ext-session": "*", | ||||||
| "ext-pcre": "*", | ||||||
| "ext-json": "*", | ||||||
| "league/container": "~3.0", | ||||||
| "doctrine/dbal": "2.9.*", | ||||||
| "psr/log": "1.1.*", | ||||||
| "patchwork/utf8": "^1.3", | ||||||
| "geekwright/assetic-fork": "^2.0", | ||||||
| "symfony/console": "^4.2", | ||||||
| "ptachoire/cssembed": "1.0.*", | ||||||
| "ext-pcre": "*", | ||||||
| "ext-session": "*", | ||||||
|
Comment on lines
+10
to
+12
|
||||||
| "ezyang/htmlpurifier": "^4.8.0", | ||||||
| "firebase/php-jwt": "^6.10.2", | ||||||
| "geekwright/assetic-fork": "*", | ||||||
|
||||||
| "geekwright/assetic-fork": "*", | |
| "geekwright/assetic-fork": "^1.0", |
mambax7 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
mambax7 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
Copilot
AI
Jun 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a specific version constraint for 'tedivm/stash' rather than '*', to ensure stability.
Suggested change
| "tedivm/stash": "*", | |
| "tedivm/stash": "^0.15.2", |
mambax7 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
mambax7 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer package names are normalized to lowercase; using "ext-PDO" is inconsistent with the other ext-* requirements (e.g., ext-json/ext-mbstring) and can be confusing. Consider renaming it to "ext-pdo" for consistency and to match Composer docs.