Update copilot-instructions.md to reflect PHP 8.2+ minimum#145
Update copilot-instructions.md to reflect PHP 8.2+ minimum#145mambax7 wants to merge 2 commits intoXOOPS:masterfrom
Conversation
The project requires PHP ^8.2 (composer.json) and CI tests 8.2-8.5. The instructions incorrectly referenced PHP 7.4, which caused CodeRabbit to flag first-class callable syntax as incompatible. Aligns copilot-instructions.md with xoops-copilot-template.md and the actual project configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note
|
| Cohort / File(s) | Summary |
|---|---|
Version Requirements & CI Configuration .github/copilot-instructions.md |
Updated PHP matrix from 7.4–8.5 to 8.2–8.5; added Scrutinizer range; expanded allowed language features to include PHP 8.0+ constructs (named arguments, match, enums, attributes, nullsafe operator, union types, readonly, etc.); added two new PR checklist items: encoding constant usage and file operation error handling compliance. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~4 minutes
Possibly related PRs
- update to PHP 8.2 as minimum #140: Complements by updating
composer.jsonto enforce minimum PHP 8.2 requirement. - CI: Add SonarCloud, fix PHPStan on PHP 7.4/8.0, refine workflows #133: Related CI workflow modifications including PHP version matrix and test configuration updates.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately reflects the main change: updating copilot-instructions.md to reflect PHP 8.2+ as the minimum version, which is the primary purpose of this PR. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Pull request overview
This PR updates the PHP compatibility documentation in .github/copilot-instructions.md to reflect the project's actual PHP version requirements. The project requires PHP ^8.2 (as specified in composer.json) and the CI pipeline tests versions 8.2-8.5, but the documentation incorrectly stated PHP 7.4 as the minimum, which caused AI code reviewers to incorrectly flag modern PHP 8.x features as incompatible.
Changes:
- Updated minimum PHP version from 7.4 to 8.2 throughout the documentation
- Added comprehensive list of allowed PHP 8.0/8.1/8.2 features (named arguments, match expressions, enums, constructor promotion, attributes, nullsafe operator, first-class callables, etc.)
- Updated all three references to PHP version ranges to consistently reflect 8.2-8.5
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/copilot-instructions.md:
- Line 34: Update the paragraph that enumerates allowed PHP features to
explicitly include PHP 8.2–specific syntax so CI won’t flag 8.2-only constructs;
append items such as "readonly classes", the "true" type, Disjunctive Normal
Form (DNF) types, trait constants, and the deprecation of dynamic properties to
the existing list of 8.0/8.1 features so the sentence now covers PHP 8.2+
constructs as well.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
The project requires PHP ^8.2 (composer.json) and CI tests 8.2-8.5. The instructions incorrectly referenced PHP 7.4, which caused CodeRabbit to flag first-class callable syntax as incompatible.
Aligns copilot-instructions.md with xoops-copilot-template.md and the actual project configuration.
Summary by CodeRabbit