Require 100% disputed transaction agreement if round takes too long

XRPLF · Feb 5, 2025 · 76c27a0 · 76c27a0
1 parent 9716f86
commit 76c27a0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/xrpld/consensus/ConsensusParms.h b/src/xrpld/consensus/ConsensusParms.h
@@ -145,6 +145,9 @@ struct ConsensusParms
     //! Percentage of nodes that must vote yes after we are stuck
     std::size_t avSTUCK_CONSENSUS_PCT = 95;
 
+    //! Percentage of previous round duration before we are frozen
+    std::size_t avFROZEN_CONSENSUS_TIME = 400;
+
     //! Percentage of nodes required to reach agreement on ledger close time
     std::size_t avCT_CONSENSUS_PCT = 75;
 };

diff --git a/src/xrpld/consensus/DisputedTx.h b/src/xrpld/consensus/DisputedTx.h
@@ -226,8 +226,12 @@ DisputedTx<Tx_t, NodeID_t>::updateVote(
             newPosition = weight > p.avMID_CONSENSUS_PCT;
         else if (percentTime < p.avSTUCK_CONSENSUS_TIME)
             newPosition = weight > p.avLATE_CONSENSUS_PCT;
-        else
+        else if (percentTime < p.avFROZEN_CONSENSUS_TIME)
             newPosition = weight > p.avSTUCK_CONSENSUS_PCT;
+        else
+            // Only keep this tx if every node agrees on it
+            // Alternately, just vote no
+            newPosition = weight >= 100;
     }
     else
     {