DRAFT: Ximinez/lending xls 66 #5270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
4 times, most recently
from
1240135 to
6f5d1ad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ximinez/Bronek/vault #5270 +/- ##
====================================================
Coverage 78.1% 78.1%
====================================================
Files 802 802
Lines 68698 68655 -43
Branches 8264 8293 +29
====================================================
- Hits 53670 53646 -24
+ Misses 15028 15009 -19
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
3 times, most recently
from
27e4c4f to
2d209c4
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
5 times, most recently
from
e8fbd22 to
a697138
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
7 times, most recently
from
72d979e to
441d5b5
Compare
ximinez
force-pushed
the
ximinez/Bronek/vault
branch
from
b1e091c to
2a8861d
Compare
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
8 times, most recently
from
5223459 to
c7b296c
Compare
- Also add new SFields, Keylet functions, and an Invariant to verify no illegal field modification
(Does not compile)
- Also add a general check for all object types for the type and index fields
- Adds a flagMask parameter to preflight1 so that it's impossible to forget to check flags. - Also adds a short hash prefix to all Transactor log messages.
- Derived classes no longer need to explicitly check amendments, nor call into preflight1 or preflight2. - Untested.
- Does not build - Transactions: LoanDelete, LoanManage, LoanDraw, LoanPay - LoanBrokerSet creation mostly done. Need update. - Also added a lookup table for pseudo account fields.
ximinez
force-pushed
the
ximinez/lending-XLS-66
branch
from
c7b296c to
3b30b28
Compare
- Update changed field name. - Modify modifiable fields in an update. Note there are only two. - Add a node field to dirLink, defaulting sfOwnerNode, so other relationships can be updated.
- Test that they work by converting some of the existing classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base branch is #5224
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)