Skip to content

Update Desktop Wallet (JS) tutorial #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2025
Merged

Update Desktop Wallet (JS) tutorial #3329

merged 3 commits into from
Oct 8, 2025

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Oct 2, 2025 •
edited
Loading

→ Preview link

Update the Build a Desktop Wallet in JavaScript tutorial with necessary fixes and a few nice-to-have improvements:

  • Update several dependencies to newest versions, including Electron (superseding Bump electron from 28.3.2 to 35.7.5 in /_code-samples/build-a-desktop-wallet/js #3273)
  • Update some old links to newer URLs.
  • Fix several broken links, especially ones to the code samples for this tutorial.
  • Add a note (in the code comments and the doc) about default algorithms in Wallet.fromSeed(...) which is a common gotcha in upgrading xrpl.js
  • Improve wording of the docs and comments in a few places, but not the whole doc. The doc is still not quite written to our style guide, but rewriting the whole thing is out of scope for this PR.
  • Replace some, but not all, instances of code blocks with {% code-snippet ... /%} components.

Created #3330 for the lower-priority follow-up tasks.

@mDuo13 mDuo13 added content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts javascript Pull requests that update Javascript code payments Relating to payment features including cross-currency payments, escrow, payment channels needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site labels Oct 2, 2025
This was referenced Oct 2, 2025
Open
Closed
maria-robobug
maria-robobug reviewed Oct 3, 2025
View reviewed changes
@mDuo13 mDuo13 requested a review from maria-robobug October 7, 2025 21:50
@mDuo13 mDuo13 merged commit b08d7f0 into master Oct 8, 2025
4 of 5 checks passed
@mDuo13 mDuo13 deleted the update_desktop_wallet_js_tutorial branch October 8, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maria-robobug maria-robobug maria-robobug approved these changes

Assignees
No one assigned
Labels
content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts javascript Pull requests that update Javascript code needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site payments Relating to payment features including cross-currency payments, escrow, payment channels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mDuo13 @maria-robobug