Clarify that --silent suppresses console logging for the entire run, not just startup - #3721
Open
pete-csyn wants to merge 1 commit into
Open
Clarify that --silent suppresses console logging for the entire run, not just startup#3721pete-csyn wants to merge 1 commit into
pete-csyn wants to merge 1 commit into
Conversation
…not just startup xrpld has a single console log sink (stderr). --silent disables it for the lifetime of the process, so any stdout/stderr-based log capture (e.g. a container log driver) receives nothing after the startup banner. The file sink configured by [debug_logfile] is independent of --silent, so pointing it at /dev/stdout restores log visibility. - commandline-usage: correct the --silent description (entire run, not only startup) - diagnosing-problems: add a container/supervisor logging note and drop the inaccurate "during startup" qualifier from the --silent link text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--silentoption forxrpld(formerlyrippled) is currently documented as suppressing standard-output/standard-error logging "during startup." In practice the flag suppresses console logging for the entire run of the process — only the pre---silentstartup banner is still printed. This is easy to trip over when runningxrpldunder a process supervisor or in a container, where the operator expects ongoing logs on the container log driver but sees only the startup banner.This PR:
--silentdescription in the Verbosity Options table on the Commandline Usage page to say it suppresses console logging for the whole run, not only startup.xrpldin the foreground without--silent, or set[debug_logfile]to/dev/stdout(the file sink keeps flowing even with--silent).Why
xrpldhas a single console log sink (standard error).--silentdisables that sink for the lifetime of the process, so any stdout/stderr-based log capture (e.g. a container log driver) receives nothing after the banner. The file sink configured by[debug_logfile]is independent of--silent, so pointing it at/dev/stdoutrestores log visibility.Test Plan
Documentation-only change. Verified the cross-page anchor (
#check-the-server-log) resolves to the existing heading on the Diagnosing Problems page, and that the{% admonition %}syntax matches existing usage in both edited files.