Skip to content

Conversation

kieranm-xilinx
Copy link
Contributor

@kieranm-xilinx kieranm-xilinx commented Sep 5, 2025

I'd welcome some early review of the approach here: it looks like the zf_timer.h code is only used in zf[udp/tcp]pingpong, so I've made the change there, but happy to do it otherwise (e.g. in zf[udp/tcp]pingpong themselves) if there's a preference for that.

I'd also welcome suggestions for testing that reviewers would like to see before this gets merged, and possibly help with getting it done if it involves test infrastructure like jenkins jobs I don't have access to.

@kieranm-xilinx
Copy link
Contributor Author

Some initial test results show a performance penalty from this change (which only affects our test apps, not customer code) of 9ns
Before: http://xcb-rb-logs.xilinx.com/users/kieranm/results/2025/09/09/0_dibench_10-39-51
After: http://xcb-rb-logs.xilinx.com/users/kieranm/results/2025/09/09/0_dibench_10-57-26

Copy link
Contributor

@jfeather-amd jfeather-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Current testing seems sufficient to me, it would be good to see further testing as discussed elsewhere but happy that this can happen after this is merged.

@jfeather-amd jfeather-amd requested a review from a team September 12, 2025 14:18
@kieranm-xilinx kieranm-xilinx merged commit 464f328 into master Sep 12, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants