feat(core): create global hasher pool #31769

[gzliudan]

Proposed changes

Ref: ethereum#31769

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e7632de7-b103-4e0f-94bb-5a38715a840f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors several hashing call sites to use shared/global Keccak hashing utilities (instead of per-component hashers/pools) and deduplicates test-only “list hasher” helpers into a single internal package.

Changes:

• Switch EVM KECCAK256 opcode and CREATE2 init-code hashing to crypto.Keccak256Hash (pool-backed) and remove the per-EVM shared hasher fields.
• Simplify trie node accessors for path-scheme by computing node hashes via crypto.Keccak256Hash and removing the local hasher pool (with accompanying signature/semantics changes to exported helpers).
• Centralize test hasher helpers into internal/blocktest and update tests/benchmarks to use it.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
core/vm/instructions.go	Uses global pooled Keccak hashing for the KECCAK256 opcode and preimage recording.
core/vm/evm.go	Removes per-EVM hasher state and uses Keccak256Hash for CREATE2 init-code hashing.
core/rawdb/accessors_trie.go	Removes local node-hasher pool and reworks path-scheme presence/read logic to hash via crypto.Keccak256Hash.
trie/trienode/node.go	Removes an exported NodeSet.Hashes helper.
internal/blocktest/test_hash.go	Adds centralized test helper hasher for DeriveSha-style list hashing.
internal/ethapi/api_test.go	Switches tests to use the shared blocktest.NewHasher.
core/types/block_test.go	Switches block benchmark helper to use blocktest.NewHasher.
core/rawdb/accessors_indexes_test.go	Switches rawdb tests to use the shared test hasher helper.
core/rawdb/accessors_chain_test.go	Switches rawdb tests to use the shared test hasher helper.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.