redesign-custom-setting-page #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is #506 not needed? |
|
No , because it had been merged and akhilesh sir told me to make new
branch.
…On Thu, Oct 19, 2023, 4:33 PM Rohit Singhal ***@***.***> wrote:
Is #506 <#506> not needed?
—
Reply to this email directly, view it on GitHub
<#510 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6524RATP7J5YBDKADSYCCTYAECGRAVCNFSM6AAAAAA6G7QE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGU4DCMJVGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
In that case, please close that PR.
Cheers,
Rohit Singhal,
CEO of Xtendify <https://xtendify.com/>
Follow me:
Twitter <https://twitter.com/RoSinghal> | LinkedIn <https://www.linkedin.com/in/rosingha>
…On Thu Oct 19, 2023, 11:11 AM GMT, Sujit Bhuva ***@***.***> wrote:
No , because it had been merged and akhilesh sir told me to make new
branch.
On Thu, Oct 19, 2023, 4:33 PM Rohit Singhal ***@***.***>
wrote:
> Is #506 <#506> not needed?
>
> —
> Reply to this email directly, view it on GitHub
> <#510 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6524RATP7J5YBDKADSYCCTYAECGRAVCNFSM6AAAAAA6G7QE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGU4DCMJVGY>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub <#510 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2R6XULTRM4FGG6WNTH2KTYAEDEJAVCNFSM6AAAAAA6G7QE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZQGYZDKMZXHE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Akhill2020
reviewed
Oct 20, 2023
| @@ -249,7 +249,7 @@ public function html() | |||
| <Span><?php _e('Please Rate Us !', 'google-calendar-events'); ?></Span> | |||
| </div> | |||
| <div class="simcal-mt-[5px] simcal-text-center simcal-font-normal simcal-text-base simcal-text-gray-500"> | |||
| <Span><?php _e('If you like Simple Calendar please Rate Us', 'google-calendar-events'); ?> </Span> | |||
| <Span> <?php _e('If you like Simple Calendar please Rate Us', 'google-calendar-events'); ?> </Span> | |||
There was a problem hiding this comment.
@sujitxtendify Please make sure you dont push unnecessary changes.
| $actions['duplicate_feed'] = | ||
| '<a href="' . | ||
| esc_url(add_query_arg(['duplicate_feed' => $post->ID, 'nonce_feed_actions' => $nonce_feed_actions])) . |
There was a problem hiding this comment.
@sujitxtendify Please take a pull and push changes. you replace changes done in a recent release.
| '">' . | ||
| __('Clone', 'google-calendar-events') . | ||
| '</a>'; | ||
| $actions['clear_cache'] = | ||
| '<a href="' . | ||
| esc_url(add_query_arg(['clear_cache' => $post->ID, 'nonce_feed_actions' => $nonce_feed_actions])) . | ||
| esc_url(add_query_arg(['clear_cache' => $post->ID])) . |
There was a problem hiding this comment.
Here also revert the recent release changes done.
| @@ -167,7 +165,7 @@ public function row_actions($actions, $post) | |||
| public function bulk_actions() | |||
| { | |||
| // Check user has permission to edit | |||
| if ((!empty($_POST) && !wp_verify_nonce($_POST['_wpnonce'], '_wpnonce')) || !current_user_can('edit_posts')) { | |||
| if (!current_user_can('edit_posts')) { | |||
There was a problem hiding this comment.
Here also revert the recent release changes done.
| @@ -235,7 +233,7 @@ public function edit_table_hooks() | |||
| */ | |||
| private function duplicate_feed($post_id) | |||
| { | |||
| if (!wp_verify_nonce($_REQUEST['nonce_feed_actions'], 'nonce_feed_actions') || !current_user_can('edit_posts')) { | |||
There was a problem hiding this comment.
Here also revert the recent release changes done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redesign figma link :- https://www.figma.com/file/kGSUK6bjNOtoEdsfbLpRNs/Simple-Calender?type=design&node-id=201-108&mode=design&t=nA2I1vsMnAc9omUz-0
you can check redesign :- https://www.screenpresso.com/=4KJlg