Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Start Date Issue in Grid View #567

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Calendar Start Date Issue in Grid View #567

merged 4 commits into from
Sep 23, 2024

Conversation

Akhill2020
Copy link
Contributor

@Akhill2020 Akhill2020 commented Aug 30, 2024

Description: To resolve Calendar Start Date Issue in Grid View I have created new time format function which conert timstamp into readable time formate by using users timezone.
Clickup: https://app.clickup.com/t/86cw8gbjx
Before: https://prnt.sc/a0f46Hk5zcZ_
after: https://www.screenpresso.com/=qwxIb

@rosinghal
Copy link
Member

@Akhill2020 #565 has the same changes. How to review this?

@Akhill2020
Copy link
Contributor Author

Akhill2020 commented Sep 2, 2024

@Akhill2020 #565 has the same changes. How to review this?

in PR 565 I was pushed changes by mistake that branch can be close, we have already released that changes. So I have created this new PR. I will push all the feedback given there in this PR and will close that PR.

What is the diff between date_i18n and $this->format_timestamp?

in date_i18n it does not give preference to timezone if we pass a timestamp in it, and in the format_timestamp function, we format the date by using timezone.

Is this condition correct !empty($simple_calendar_auth_site_token && $is_authhelper)? Why two conditions inside empty?

Yes, it is checking for both variables; both should have value.

What's the diff between admin_init and init?

admin_init will work only in admin and init is work on both admin and on front end page load.

@Akhill2020 Akhill2020 mentioned this pull request Sep 2, 2024
@Akhill2020 Akhill2020 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 389e763 Sep 23, 2024
2 checks passed
@Akhill2020 Akhill2020 deleted the issue-start-date branch September 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants