Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR separates the GUI component from the main binary by introducing a new "monolith-gui" executable and its associated components. Key changes include:
- Adding a new module and tests for format_output_path to standardize output file naming.
- Refactoring src/main.rs to use the shared format_output_path function.
- Introducing a new GUI in src/gui.rs powered by Druid, with corresponding Cargo.toml configuration updates.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/core/mod.rs | Added module import for format_output_path |
| tests/core/format_output_path.rs | New tests ensuring proper replacement of placeholders in output paths |
| src/main.rs | Replaced manual string replacements with a call to format_output_path |
| src/gui.rs | New GUI implementation integrating Druid and utilizing shared formatting logic |
| src/core.rs | Added format_output_path function for consistent output path formatting |
| Cargo.toml | Updated dependencies and added a binary configuration for the GUI executable |
Files not reviewed (1)
- Makefile: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate binary (
monolith-gui)