feat: Throw exception when template id don't exist on Brevo #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckenziearts
force-pushed
the
throw-exception-on-templateId
branch
from
23eefa9 to
b12f694
Compare
JamesHemery
requested changes
Aug 19, 2024
Comment on lines
+50
to
+54
| $templateResponse = $this->http->get('/smtp/templates/' . $email->templateId); | ||
|
|
||
| if (! $templateResponse->successful()) { | ||
| throw new BrevoException($templateResponse->toPsrResponse()); | ||
| } |
There was a problem hiding this comment.
suggestion: mettre en place du cache pour cette requête ? Qui ne soit pas activé en dev.
There was a problem hiding this comment.
question : l'erreur n'est pas remontée directement par l'endpoint send ?
There was a problem hiding this comment.
Non. En gros y'a 2 éléments que je voulais tester. Savoir déjà si le template existe et savoir s'il est actif. Actuellement nous avons aucun retour quand il y'a un souci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.