Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail a bit more how an app should SSO-logout #2557

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fflorent
Copy link
Contributor

@fflorent fflorent commented Feb 9, 2025

Problem

Solution

  • I propose to mention that the app has to redirect to the main domain to make this route work: /yunohost/sso/?action=logout

PR checklist

  • PR finished and ready to be reviewed

@fflorent fflorent marked this pull request as draft February 9, 2025 13:28
@fflorent
Copy link
Contributor Author

fflorent commented Feb 9, 2025

Converting to draft, as it does not work like described anymore since Yunohost 12.

@alexAubin
Copy link
Member

Discussed on the chat the other day, no time to iterate on this right now but the correct URI is /yunohost/portalapi/logout?referer_redirect (which will redirect to the referer of the redirect after being logged out)

The domain part should be the "topest domain" for the app's domain ... or maybe it does work with the app's (sub)domain too ? Needs to be tested ...

@zamentur
Copy link
Member

zamentur commented Feb 16, 2025

I tried this redirect api endpoint with nextcloud, but sadly the redirection is not made due to no-referer policy in nextcloud nginx app /o.

https://github.com/YunoHost-Apps/nextcloud_ynh/blob/2414a029fddf01a5e5b2a53878d02f24441a90c3/conf/nginx.conf#L67

@fflorent
Copy link
Contributor Author

The domain part should be the "topest domain" for the app's domain ... or maybe it does work with the app's (sub)domain too ? Needs to be tested ...

It did not work with a subdomain. I don't know how to get the topest domain properly.

@fflorent
Copy link
Contributor Author

I achieved something using this command: yunohost --json domain info $domain | jq -r '.topest_parent // "'$domain'"'. Does this look accurate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants