Helpers / app resources: simplify helpers and implement new resources for nodejs/ruby/go/composer #2042
+790
−382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe the good time to switch nodejs from https://github.com/tj/n to https://github.com/nodenv/nodenv There is also other *env available, can be seen as https://github.com/momo-lab/xxenv-latest |
alexAubin
force-pushed
the
new-resources
branch
3 times, most recently
from
e777f52 to
b8dd383
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alexAubin
force-pushed
the
new-resources
branch
3 times, most recently
from
060593a to
5884bb7
Compare
alexAubin
force-pushed
the
new-resources
branch
3 times, most recently
from
7167be1 to
adda31a
Compare
…simplify setting up rbenv and goenv
… the nodejs/ruby/go resource
alexAubin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Redundant code in app packages, nodejs / ruby / go / composer should be managed declaratively like apt deps etc
Solution
Implement them as resource
PR Status
Kinda yolo, not complete
The code is kind of a mess because it needs to call bash commands with proper env vars x_x