Add check_status on UPnP device, rework how to detect if there is an UPnP device #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kay0u
commented
Mar 6, 2025
| @@ -189,7 +189,10 @@ class YunoUPnP: | |||
| def __init__(self, firewall: "YunoFirewall") -> None: | |||
| self.firewall = firewall | |||
| self.description = "Yunohost firewall" | |||
| self.upnpc: miniupnpc.UPnP | None = None | |||
| self.upnpc = miniupnpc.UPnP() | |||
| self.upnpc.localport = self.UPNP_PORT | |||
There was a problem hiding this comment.
I'm not sure why we define a port here, it works with the default one.
kay0u
commented
Mar 6, 2025
Comment on lines
203
to
204
| def ensure_listen_port(self) -> None: | ||
| self.firewall.open_port("udp", self.UPNP_PORT, self.UPNP_PORT_COMMENT) |
There was a problem hiding this comment.
This function is never called, I think we can remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
...
Solution
...
PR Status
Tested on my prod lul
How to test
...