Repository navigation
Update ncm-converter to v2.4.0: 修复 files 指令 schema + 右下角完成提示窗 - #719
Merged
lzx8589561 merged 1 commit intoNov 4, 2026
Merged
Conversation
akahoz94
force-pushed
the
plugin/ncm-converter-v2.4.0
branch
2 times, most recently
from
October 30, 2026 18:20
1d3a0b3 to
2c96519
Compare
akahoz94
force-pushed
the
plugin/ncm-converter-v2.4.0
branch
from
October 30, 2026 18:22
2c96519 to
f593a5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 ncm-converter v2.3.0 导致的插件失效,并新增完成提示窗
一、为什么必须升到 2.4.0(版本号不能往回走)
插件市场的版本号直接取自
plugin.json(scripts/build-plugins.js用它给 zip 命名 →scripts/generate-plugins-json.js用它写进plugins.json),ZTools 客户端用语义化版本比较(
comparePluginVersions,2.4.0 > 2.3.0)决定是否推送更新。线上当前版本是 2.3.0。如果这次沿用 2.2.1 推上去,市场清单会从 2.3.0 降到 2.2.1,
已经装了 2.3.0 的用户永远收不到修复,这就是「版本号往下降」。
所以本次版本号提到 2.4.0(> 2.3.0),保证推送链路通畅。规则:版本号只能递增。
二、v2.3.0 为什么会让插件「用不了」
v2.3.0 把
files指令的扩展名从平铺改成了嵌进match对象:但 ZTools 客户端的解析逻辑(
out/main/chunks/searchWorker.js)是:因此 v2.3.0 有两个后果:
字段 match 应为 string),type:files指令注册失败 → 插件整体用不了。cmd.extensions变成了undefined),任意文件都能触发该指令。本次改回 v2.2.1 的平铺写法(已被证实可用):
三、新增:转换完成后的右下角提示窗 + 提示音
对齐「音频提取」插件的反馈方式,三条通道互为兜底:
createBrowserWindow弹出无边框、置顶、不占任务栏、不抢焦点的小窗,列出每个文件的成功/失败(失败项标红),5 秒后自动关闭。可用
dbStorage的toast_corner切成左下角(
br/bl)。shellBeep()。关键实现细节:小窗属于插件进程,宿主要等
enter的 Promise resolve 后才退出插件,所以
handle()里 dwell 5.5 秒再返回,否则窗口会被一起销毁、用户根本看不到提示。四、保留 v2.3.0 的健壮性改进
-map 0:a:0,跳过封面流导致的转码失败%TEMP%/ncm-converter-debug.log五、验证
用 ZTools 客户端的真实解析逻辑(逐字抄自
searchWorker.js)跑新旧两份plugin.json:全链路自检(真实 ffmpeg):
六、影响面
只改
plugins/ncm-converter/,不涉及其他插件,也不改动任何 workflow。合并后
build-and-release.yml会自动打包发布ncm-converter-2.4.0.zip,并把市场清单里的版本更新为 2.4.0。
七、关于 CHANGELOG.md(未包含在本 PR 内)
plugins/ncm-converter/CHANGELOG.md没有放进这个 PR,原因是它在上游是在本分支基线之后才新增的,两边都算「新增」会导致 add/add 冲突(GitHub 标记为 CONFLICTING)。
为保证本 PR 零冲突、可以直接合并,这里只提交了 4 个文件。
CHANGELOG.md需要补的 2.4.0 条目内容如下,合并后追加即可(或后续单独提一个 PR):