fix: store calendar OAuth credentials after authentication - #692
Open
anxkhn wants to merge 1 commit into
Open
Conversation
anxkhn
force-pushed
the
fix/calendar-agent-store-oauth
branch
2 times, most recently
from
August 25, 2026 18:04
3535094 to
f5dc2cb
Compare
Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
anxkhn
force-pushed
the
fix/calendar-agent-store-oauth
branch
from
August 25, 2026 18:04
f5dc2cb to
40e6174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #275.
The calendar agent only cached exchanged OAuth credentials when
RequestContext.call_context.user.is_authenticatedwas true. The documented/authenticatecallback has no bearer JWT, so_complete_auth_processingskipped_store_user_authand later requests prompted for authorization again.This change makes
_complete_auth_processingstore credentials after a successful callback and updates_store_user_authto usesession.user_id, matching the key used by_ensure_auth. It also adds a regression test covering an unauthenticated callback and verifying that the session credential is cached.Tested with: